fix(sdk): have getMessageStatus call messenger #8212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getMessageStatus was previously using event queries to figure out the status of the given message. We can do the same thing by making requests directly to the messenger contracts which is more reliable because most RPC endpoints won't allow massive block ranges.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #8212 +/- ##
============================================
- Coverage 53.68% 40.92% -12.77%
============================================
Files 162 27 -135
Lines 6072 1703 -4369
Branches 966 381 -585
============================================
- Hits 3260 697 -2563
+ Misses 2690 1006 -1684
+ Partials 122 0 -122
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Semgrep found 1
Prefer Semgrep found 1
Inputs to functions must be prepended with an underscore ( |
roninjin10
approved these changes
Nov 21, 2023
Merged
nitaliano
pushed a commit
that referenced
this pull request
May 20, 2024
…-fix fix(sdk): have getMessageStatus call messenger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getMessageStatus was previously using event queries to figure out the status of the given message. We can do the same thing by making requests directly to the messenger contracts which is more reliable because most RPC endpoints won't allow massive block ranges.x